Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring code in src/upgrades/1.0.0/chat_room_hashes.js #27

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

dominicteh1
Copy link

Added new processChatRoom function to reduce function nesting to less than 4 levels

@dominicteh1 dominicteh1 added this to the Sprint 1 milestone Sep 12, 2024
@dominicteh1 dominicteh1 self-assigned this Sep 12, 2024
Copy link

@a1inachen a1inachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10836752191

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 82.67%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10836700957: -0.005%
Covered Lines: 22325
Relevant Lines: 25585

💛 - Coveralls

@dominicteh1 dominicteh1 merged commit 05afb1a into f24 Sep 12, 2024
1 check passed
@dominicteh1 dominicteh1 deleted the dominic-p1-changes branch September 12, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants