Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Frontend Repo to Workflow Deployment #51

Merged
merged 14 commits into from
Oct 24, 2024
Merged

Conversation

a1inachen
Copy link

@a1inachen a1inachen commented Oct 22, 2024

What?

Why?

The current deployment only have the changes made to the backend, they are inaccessible without the frontend changes in the other repository.

How?

  • Add to the deployment workflow in the file azure-deploy-f24.yml to install the theme from the frontend repository

Testing?

  • Deployed to the website here and see the frontend changes reflected

Screenshots

US1 (preview in category page) and US2 (solve/unsolve in category page)
image

US2 (solve/unsolve in topic page) and US4 (endorse replies)
image

Anything Else?

Thank you

@coveralls
Copy link

coveralls commented Oct 22, 2024

Pull Request Test Coverage Report for Build 11469412604

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.677%

Totals Coverage Status
Change from base Build 11444961491: 0.0%
Covered Lines: 22372
Relevant Lines: 25637

💛 - Coveralls

@Michaelli8899 Michaelli8899 added this to the Project 3 milestone Oct 22, 2024
Copy link

@Michaelli8899 Michaelli8899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good

Copy link

@bythehills bythehills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@a1inachen a1inachen added testing enhancement New feature or request and removed enhancement New feature or request testing labels Oct 23, 2024
Copy link

@dominicteh1 dominicteh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is good, setup looks good

@Michaelli8899 Michaelli8899 merged commit 59a04fb into f24 Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants