Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cmake workflow #7

Open
4 of 5 tasks
maximilianmordig opened this issue Jun 9, 2024 · 0 comments
Open
4 of 5 tasks

Improve cmake workflow #7

maximilianmordig opened this issue Jun 9, 2024 · 0 comments
Assignees

Comments

@maximilianmordig
Copy link
Collaborator

maximilianmordig commented Jun 9, 2024

Ordered by priority:

  • cmake should build both targets rawhash2, rawhash2_usinglib without having to modify the option build_cli (i.e. remove this option and build both targets): currently not possible due to defining target twice --> please clean up the logic to have one function that defines a target (like pod5 target) and another that adds this target to another target (like rawhash).
    clean up so that there is one

  • also check that the shared lib can be successfully loaded, i.e. all dependent shared libs are found

  • Make make install work with a custom prefix and document in README (i.e. not necessarily $HOME/.local or similar), should put things to $INSTALL_DIR/bin, $INSTALL_DIR/include, $INSTALL_DIR/lib. Currently, they are in subfolders that one first needs to find. lib should contain the shared rawhash library (and dependent shared libs), bin the rawhash cli and include the wrapper rawhash_wrapper.hpp.

  • allow to disable caching of the build directory (by checking for the presence of a file in the repo, or setting an option in the workflow (possibly with workflow variables))

  • build is slow (13 minutes, in particular because of tflite). This happens because of make looking at file timestamps. When tflite is checked out in the new build, the modification time becomes the time of the build, not when it was built originally. For example, you could copy tflite with cmake to the build directory and then build from there, but only copy it there if the hash of the directory has changed.

@maximilianmordig maximilianmordig changed the title Improve cmake Improve cmake workflow Jun 9, 2024
@adamant-pwn adamant-pwn self-assigned this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants