You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cmake should build both targets rawhash2, rawhash2_usinglib without having to modify the option build_cli (i.e. remove this option and build both targets): currently not possible due to defining target twice --> please clean up the logic to have one function that defines a target (like pod5 target) and another that adds this target to another target (like rawhash).
clean up so that there is one
also check that the shared lib can be successfully loaded, i.e. all dependent shared libs are found
Make make install work with a custom prefix and document in README (i.e. not necessarily $HOME/.local or similar), should put things to $INSTALL_DIR/bin, $INSTALL_DIR/include, $INSTALL_DIR/lib. Currently, they are in subfolders that one first needs to find. lib should contain the shared rawhash library (and dependent shared libs), bin the rawhash cli and include the wrapper rawhash_wrapper.hpp.
allow to disable caching of the build directory (by checking for the presence of a file in the repo, or setting an option in the workflow (possibly with workflow variables))
build is slow (13 minutes, in particular because of tflite). This happens because of make looking at file timestamps. When tflite is checked out in the new build, the modification time becomes the time of the build, not when it was built originally. For example, you could copy tflite with cmake to the build directory and then build from there, but only copy it there if the hash of the directory has changed.
The text was updated successfully, but these errors were encountered:
Ordered by priority:
cmake should build both targets
rawhash2
,rawhash2_usinglib
without having to modify the optionbuild_cli
(i.e. remove this option and build both targets): currently not possible due to defining target twice --> please clean up the logic to have one function that defines a target (like pod5 target) and another that adds this target to another target (like rawhash).clean up so that there is one
also check that the shared lib can be successfully loaded, i.e. all dependent shared libs are found
Make
make install
work with a custom prefix and document in README (i.e. not necessarily $HOME/.local or similar), should put things to$INSTALL_DIR/bin, $INSTALL_DIR/include, $INSTALL_DIR/lib
. Currently, they are in subfolders that one first needs to find.lib
should contain the shared rawhash library (and dependent shared libs),bin
the rawhash cli andinclude
the wrapperrawhash_wrapper.hpp
.allow to disable caching of the build directory (by checking for the presence of a file in the repo, or setting an option in the workflow (possibly with workflow variables))
build is slow (13 minutes, in particular because of tflite). This happens because of
make
looking at file timestamps. When tflite is checked out in the new build, the modification time becomes the time of the build, not when it was built originally. For example, you could copy tflite with cmake to the build directory and then build from there, but only copy it there if the hash of the directory has changed.The text was updated successfully, but these errors were encountered: