Use Tags for Dependencies with FetchContent_Declare

[dschiller]

Is your feature request related to a problem? Please describe.
You introduced a breaking change with 393a85e for all your dependencies (CMaize).

Describe the solution you'd like
For all your dependencies you also need to pin to tags with the GIT_TAG attribute (see https://cmake.org/cmake/help/latest/module/FetchContent.html) to not introduce breaklng changes.

Describe alternatives you've considered
Forking your CMakeTest repro and fix the FetchContent_Declare usage by using tags.

Additional context
It is good practice to pin to a tag instead to the master branch for dependencies. This is related to #64

[ryanmrichard]

@dschiller apologies, but I want to make sure I understand exactly what needs pinning. Are you referring pinning the version of CMaize we use in CMakeTest? That would require adding GIT_TAG here. If so, I absolutely agree. We should have been doing that from the start, and I just opened #98 to address that. Otherwise, can you please provide a bit more information as to what broke?

[dschiller]

Yes Ryan, pinning the version of CMaize and all future Dependencies of CMakeTest to a specific tag. Regarding our broken code we believe that you changed the Cpp repository from public to private which made our code fail as we didn't update to use CMaize that time you switched to CMaize. However, pinning to a tag should be used for your repositories anyways for dependencies.

[ryanmrichard]

@dschiller just to clarify, CMaize is Cpp. We renamed it. Nonetheless, #98 pins CMakeTest's dependencies so hopefully this issue won't come up again.

[dschiller]

Okay, thank you for the clarification Ryan. And also thank you a lot for this fast solution!