-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flipped solar units in design table? #160
Milestone
Comments
bpbond
changed the title
Flipped solar unit in design table
Flipped solar units in design table?
May 1, 2024
Yes, I think variable names/units are correct -- you can look at variable names to confirm. |
Sorry, does that mean you agree that the COMPASS-FME units are flipped by accident? |
Yes, I think the metadata units are flipped by accident and the units hard-coded into the loggernet variable are correct. |
bpbond
added a commit
that referenced
this issue
May 7, 2024
Merged
bpbond
added a commit
that referenced
this issue
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following up on #158 , from our variable metadata file:
But...
W/m2 = J/s/m2 is a rate
MJ/m2 = amount of energy
So it seems like the "total solar flux" should be in MJ/m2, and the "average" should be W/m2...are the units flipped for these entries?
💡 Ah the variable names have the correct units! OK, so I think our entries are wrong.
@stephpenn1 @roylrich @selinalcheng Is this right? I mean, is it right that the metadata table is wrong? Thanks
The text was updated successfully, but these errors were encountered: