Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flipped solar units in design table? #160

Closed
bpbond opened this issue May 1, 2024 · 3 comments · Fixed by #167
Closed

Flipped solar units in design table? #160

bpbond opened this issue May 1, 2024 · 3 comments · Fixed by #167
Assignees
Milestone

Comments

@bpbond
Copy link
Member

bpbond commented May 1, 2024

Following up on #158 , from our variable metadata file:

Screenshot 2024-05-01 at 2 37 26 PM

But...
W/m2 = J/s/m2 is a rate
MJ/m2 = amount of energy

So it seems like the "total solar flux" should be in MJ/m2, and the "average" should be W/m2...are the units flipped for these entries?

💡 Ah the variable names have the correct units! OK, so I think our entries are wrong.

@stephpenn1 @roylrich @selinalcheng Is this right? I mean, is it right that the metadata table is wrong? Thanks

@bpbond bpbond changed the title Flipped solar unit in design table Flipped solar units in design table? May 1, 2024
@bpbond bpbond self-assigned this May 4, 2024
@bpbond bpbond added this to the L1 v1-0 milestone May 4, 2024
@selinalcheng
Copy link
Collaborator

Yes, I think variable names/units are correct -- you can look at variable names to confirm.

@bpbond
Copy link
Member Author

bpbond commented May 7, 2024

Sorry, does that mean you agree that the COMPASS-FME units are flipped by accident?

@selinalcheng
Copy link
Collaborator

Yes, I think the metadata units are flipped by accident and the units hard-coded into the loggernet variable are correct.

@bpbond bpbond linked a pull request May 7, 2024 that will close this issue
bpbond added a commit that referenced this issue May 8, 2024
* Add metadata required to map GCReW met to GCW-W
* Remove GCW mappings as no met station or sonde
* Fix solar total/flux units for 15min data #160
* Clean up reset() function
* Add site and plot back in; see #169
* Remove option to remove input files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants