-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to retain dedicated plot column for TMP L1 #169
Comments
Thanks @peterregier Why it is "only apply to TEMPEST"? Plot is a crucial piece of information everywhere else too, right? What about Site? Should that have its own dedicated column? Curious about your thoughts here.
That's definitely a priority, so I'm very open to this. Just would like to understand better why something like this seems onerous: # Read in all the 2024 TEMPEST control plot data
f <- list.files("TMP_2024/", pattern = "TMP_C_", full.names = TRUE)
dat <- bind_rows(lapply(f, read_csv))
dat$Site <- "TMP"
dat$Plot <- "C" |
Just making a note, adding "Site" and "Plot" columns to one of the 2024 TEMPEST files (I tested |
@bpbond my instinct on "easier" comes from my solution of parsing filenames with stringr::str_extract(name, "(?<=)[^_]+(?=)") when reading all csvs from a given L1 folder (eg TMP_2023). Absolutely agree your solution is not onerous, just hoping to keep the data as easy as possible for folks of all to use, if folks don't have to parse strings or assign, that's one less barrier in my mind. I think you're absolutely right, having transect location as an equivalent variable would make sense for synoptics! Adding site as a column makes sense to me too. I recognize wanting to keep things lightweight, just putting in my 2 cents on that balance. |
It does seem penny-wise, pound-foolish to save 10% in file sizes but force everyone to again and again parse filenames to re-create those Thoughts @selinalcheng @roylrich @wilsonsj100 ? |
Addressed in #167 |
Sorry for the late input, but I am pro adding the zone back in! Thank you! |
agreed
Roy Rich PhD.
Research Ecologist
Smithsonian Environmental Research Center
647 Contees Wharf Rd.
Edgewater, MD USA 21037
Cell 651-328-4391
***@***.******@***.***>
https://serc.si.edu/technology-in-ecology
…________________________________
From: Stephanie J Wilson ***@***.***>
Sent: Wednesday, May 8, 2024 9:09 AM
To: COMPASS-DOE/data-workflows ***@***.***>
Cc: Rich, Roy ***@***.***>; Mention ***@***.***>
Subject: Re: [COMPASS-DOE/data-workflows] Request to retain dedicated plot column for TMP L1 (Issue #169)
External Email - Exercise Caution
Sorry for the late input, but I am pro adding the zone back in! Thank you!
—
Reply to this email directly, view it on GitHub<#169 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFIDRBXQCXNCQKFVFDPH3ELZBIPYRAVCNFSM6AAAAABHLWDZQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBQGU2DANZRHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I just pulled L1 data and it appears the plot column included in prior releases is now removed and instead in the filename. I recognize and appreciate trying to reduce redundancy and am happy to parse from filenames, but as critical metadata all TEMPEST analyses will need, I think it warrants a dedicated column for ease of use. I'm intending this comment to only apply to TEMPEST.
The text was updated successfully, but these errors were encountered: