Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 beta checklist #49

Closed
3 of 5 tasks
bpbond opened this issue Nov 2, 2023 · 6 comments
Closed
3 of 5 tasks

L1 beta checklist #49

bpbond opened this issue Nov 2, 2023 · 6 comments

Comments

@bpbond
Copy link
Member

bpbond commented Nov 2, 2023

Synthesized from the Google doc

Feedback from SP/RR/SC

Feedback from PR and others

  • Finish instrument bounds and units in schema template
  • Flag cleanup (see SP's notes in google doc)
@bpbond
Copy link
Member Author

bpbond commented Nov 2, 2023

Current file format:

Screenshot 2023-11-02 at 3 37 48 PM

@stephpenn1
Copy link
Member

I removed units (available in metadata) and old_value (available in L0); remove Site column too? @stephpenn1 It's available in filename...but maybe this would be a pain for users

  • Units: I think we should make the unit format a question on the beta google form (i.e should we put them in the variable name, keep as separate column, or put into metadata file)
  • Site: it's in the design link too, so I'm more inclined to remove this column

@stephpenn1
Copy link
Member

not sure if we've added this in, but an additional L1 flag could be the -99999 reading on certain sensors (see meeting doc)

bpbond added a commit that referenced this issue Nov 7, 2023
bpbond added a commit that referenced this issue Nov 7, 2023
* Drop site column per @stephpenn1 #49
* Update L1_metadata_template.txt
@bpbond bpbond mentioned this issue Nov 7, 2023
9 tasks
@bpbond
Copy link
Member Author

bpbond commented Nov 10, 2023

@bpbond
Copy link
Member Author

bpbond commented Dec 7, 2023

Linking to @stephpenn1 's better plotting code to be able to find it later: #61 (comment)

@bpbond bpbond added this to the L1 milestone Dec 22, 2023
@bpbond
Copy link
Member Author

bpbond commented Dec 22, 2023

We're good here

@bpbond bpbond closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants