Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only most recent commit author in JSON feed #29

Open
TysonMN opened this issue Jan 28, 2021 · 2 comments
Open

Only most recent commit author in JSON feed #29

TysonMN opened this issue Jan 28, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@TysonMN
Copy link
Contributor

TysonMN commented Jan 28, 2021

I just added support for RSS to my blog by following the coding-blog-plugin documentation for RSS. Here is one thing that isn't quite right.

The JSON feed (for example) says author for this post (live, source) is Rawr (probably because he lasted edited that file) even though I used the Author component to assign authorship to "Tyson Williams" (see line five of the markdown).

How can I tell the RSS generating code that I am the author of this post?

@loreanvictor loreanvictor added the bug Something isn't working label Jan 28, 2021
@loreanvictor
Copy link
Contributor

so this is a bug and a feature request :)))

the bug is that it is supposed to include all commit authors, not just the author of the last commit. maybe this is how JSON feed handles the situation? can you look into other emitted RSS files as well?

the requested feature is to be able to include an author using the Author component that is not listed in commit authors (if I am not mistaken), or outright overriding the authors using the Author component. which is also understandable (but would require a separate issue).

@TysonMN TysonMN changed the title RSS generated author wrong RSS generated author only the most recent editor Jan 28, 2021
@TysonMN TysonMN changed the title RSS generated author only the most recent editor Only most recent commit author in JSON feed Jan 28, 2021
@TysonMN
Copy link
Contributor Author

TysonMN commented Jan 28, 2021

the bug is that it is supposed to include all commit authors, not just the author of the last commit. maybe this is how JSON feed handles the situation? can you look into other emitted RSS files as well?

Oh, only the JSON feed has this problem. It also has another problem, which is that none of authors include an email address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants