Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer Hero Images for Better Loading Speed #5

Open
loreanvictor opened this issue Jun 18, 2020 · 1 comment
Open

Defer Hero Images for Better Loading Speed #5

loreanvictor opened this issue Jun 18, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@loreanvictor
Copy link
Contributor

Hero images are not essential to the content, and they take long to load on low internet speeds, blocking access to the whole page. They should be deferred so that they don't block the page and main content.

@loreanvictor loreanvictor added the enhancement New feature or request label Jun 18, 2020
@loreanvictor
Copy link
Contributor Author

this commit will speed up loading of hero images as it now uses <picture> tag to avoid loading different sizes for responsive heroes. caveats:

  • <picture> is not supported on IE 11 (so no more hero images on IE 11)
  • the same approach is not applicable to dark-mode light-mode hero images since the OS might not support dark mode / light mode settings and so media queries cannot be applied to read such settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant