Some changes to the build.shs script #88
Merged
+2
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not append the git hash to the executable anymore - installation is done purely with the "cmake --install" - installation directory is now a subdirectory of the directory where the script is to be found, named after the build type (e.g., access-om3/Release)
|
@aekiss @dougiesquire Happy to get some feedback about these changes. |
dougiesquire
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Seems fine to me. I guess the Wiki will need updating. It would also be good to have info on installing with spack (I didn't see it).
|
Seems ok to me, since it's still possible to determine the source code for any executable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to the build.sh script:
The idea is that we should now use spack to install Access-OM3 on gadi, so there should be no need of appending the git hashes to the executables.