Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spatial_selection.ipynb notebook #272

Closed
navidcy opened this issue Sep 2, 2023 · 4 comments · Fixed by #278
Closed

Update Spatial_selection.ipynb notebook #272

navidcy opened this issue Sep 2, 2023 · 4 comments · Fixed by #278
Assignees

Comments

@navidcy
Copy link
Collaborator

navidcy commented Sep 2, 2023

At the moment this notebook does not run. We need to update it and then add it to the list of automated tests in
https://github.com/COSIMA/cosima-recipes/blob/main/test/test_notebooks.py

If we can make it work with MOM6 output it'd be even better!

@navidcy
Copy link
Collaborator Author

navidcy commented Sep 2, 2023

Also good idea is to deal with #267 while updating the notebook

@lidefi87
Copy link
Collaborator

lidefi87 commented Sep 3, 2023

I have some code that creates a mask based on a polygon that we can then use to extract data. This would be useful if the study of interest has a boundary that is more complex than a rectangle/square. Do you think this could be added here or it would be better in a new notebook?

@navidcy
Copy link
Collaborator Author

navidcy commented Sep 3, 2023

If it's 1-2 cells then definitely add to this notebook. Is it much longer than that?

Also as discussed in #246 we should put this notebook under "Tutorials".

@lidefi87 are you joining tomorrow's hackathon? wanna undertake this task?

@lidefi87
Copy link
Collaborator

lidefi87 commented Sep 3, 2023

I think it'll be more than 2 code chunks. Maybe I can make a new example under Tutorials in that case.

I was thinking of joining for about an hour when I go for lunch, which is often later than usual lunch time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants