From c423f5246c3bfff5884153b59af138c48ecb08ee Mon Sep 17 00:00:00 2001 From: "Navid C. Constantinou" Date: Wed, 6 Sep 2023 11:12:20 +1000 Subject: [PATCH] Exception -> ValueError --- regional_mom6/regional_mom6.py | 2 +- tests/test_grid_generation.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/regional_mom6/regional_mom6.py b/regional_mom6/regional_mom6.py index 0533c2e9..0cf55ac7 100644 --- a/regional_mom6/regional_mom6.py +++ b/regional_mom6/regional_mom6.py @@ -305,7 +305,7 @@ def quadilateral_area(v1, v2, v3, v4): & np.isclose(np.dot(v1, v1), np.dot(v3, v3)) & np.isclose(np.dot(v1, v1), np.dot(v4, v4)) ): - raise Exception("vectors provided must have the same length") + raise ValueError("vectors provided must have the same length") R = np.sqrt(np.dot(v1, v1)) diff --git a/tests/test_grid_generation.py b/tests/test_grid_generation.py index 499afae0..0be9f4a8 100644 --- a/tests/test_grid_generation.py +++ b/tests/test_grid_generation.py @@ -64,7 +64,7 @@ def test_quadilateral_area(v1, v2, v3, v4, true_area): def test_quadilateral_area_exception(): - with pytest.raises(Exception) as excinfo: + with pytest.raises(ValueError) as excinfo: quadilateral_area(v1, v2, v3, v4) assert str(excinfo.value) == "vectors provided must have the same length"