Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Client is unable to subscribe to Eventgroup with a client multicast endpoint #817

Open
chw-eng opened this issue Nov 25, 2024 · 1 comment
Labels

Comments

@chw-eng
Copy link

chw-eng commented Nov 25, 2024

vSomeip Version

v3.4.10

Boost Version

1.76

Environment

Embedded Linux

Describe the bug

According to SOME/IP SD spec R22-11:
[PRS_SOMEIPSD_00846] dA SubscribeEventgroup entry reference the endpoints (IP
address, port, and protocol) where the client wishes to receive the events. A client
service could subscribe to the same Eventgroup either with a client unicast endpoint
or with a client multicast endpoint:
• If a client subscribes with a client unicast endpoint via an Endpoint Option, the
client announces its desire to receive the events as unicast events transmitted to
the given unicast endpoint.
• If a client subscribes with a client multicast endpoint via an Endpoint Option, the
client announces its desire to receive the events as multicast events transmitted
to the given multicast endpoint

But it doesn't seem current vSomeip support this option.
See the implementation of service_discovery_impl::create_eventgroup_entry:
There are only two places to create unicast endpoint for tcp and udp:
https://github.com/COVESA/vsomeip/blob/master/implementation/service_discovery/src/service_discovery_impl.cpp#L916
https://github.com/COVESA/vsomeip/blob/master/implementation/service_discovery/src/service_discovery_impl.cpp#L970

We need vSomeip to implement multicast endpoint for subscribeeventgroup to satisfy [PRS_SOMEIPSD_00846]

Reproduction Steps

No response

Expected behaviour

No response

Logs and Screenshots

No response

@chw-eng chw-eng added the bug label Nov 25, 2024
@chw-eng chw-eng changed the title [BUG]: Client is unable to subscribe to Eventgroup either with a client multicast endpoint [BUG]: Client is unable to subscribe to Eventgroup with a client multicast endpoint Nov 25, 2024
@goncaloalmeida
Copy link
Contributor

@chw-eng This seems like a discussion, not a bug.

Would you be willing to create a PR with the necessary changes?

cc @duartenfonseca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants