Unittest: add a test folder v1 #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audoan99
changed the title
HarshaMM
reviewed
Mar 3, 2023
HarshaMM
reviewed
Mar 3, 2023
audoan99
force-pushed
the
devel/unit_test
branch
from
445dfb6 to
999b9af
Compare
efriedrich
reviewed
Mar 23, 2023
audoan99
force-pushed
the
devel/unit_test
branch
2 times, most recently
from
a93e13e to
18d1b4a
Compare
audoan99
force-pushed
the
devel/unit_test
branch
3 times, most recently
from
f1bfbc7 to
af4fbb8
Compare
|
Tested-by: Au Doan Ngoc [email protected] |
khangtb1
reviewed
Apr 21, 2023
khangtb1
reviewed
Apr 21, 2023
This folder consists of 3 parts: - client: test ivi-layermanagement-api (ilmCommon, ilmControl, ilmInput). - server: test ivi-id-agent-modules, ivi-input-modules and weston-ivi-shell. - common: contains common fake APIs for both client and server. Signed-off-by: Au Doan Ngoc <[email protected]>
Add the unittest folder to cmake file. Signed-off-by: Au Doan Ngoc <[email protected]>
audoan99
force-pushed
the
devel/unit_test
branch
from
cf600c7 to
ecefb9d
Compare
To build with unittests, need to use flag BUILD_ILM_UNIT_TESTS. Signed-off-by: Au Doan Ngoc <[email protected]>
khangtb1
force-pushed
the
devel/unit_test
branch
from
ecefb9d to
8d4a59d
Compare
These unittest are written for weston 9. Now weston version is 12 In this commit, let disable some testcase called removed APIs, delete get function pointer of private function in source code, let include directly source file and call private function directly. Signed-off-by: Phung Van Chien <[email protected]>
chienpv1
force-pushed
the
devel/unit_test
branch
from
8a12e6f to
66b3115
Compare
Screenshot feature have new public APIs. Some exist APIs are changed with new logic and mechanism Create unittest for new APIs, update out-of-date testcase. Signed-off-by: Phung Van Chien <[email protected]>
chienpv1
force-pushed
the
devel/unit_test
branch
from
139e1df to
ca423b5
Compare
khangtb1
reviewed
Oct 27, 2023
| ############################################################################ | ||
|
|
||
| CMAKE_MINIMUM_REQUIRED(VERSION 2.6) | ||
|
|
There was a problem hiding this comment.
The warning messages when configuring of cmake.
change to: 65fa39b
khangtb1
reviewed
Oct 27, 2023
|
|
||
| CMAKE_MINIMUM_REQUIRED(VERSION 2.6) | ||
| cmake_policy(SET CMP0046 OLD) | ||
|
|
There was a problem hiding this comment.
The warning messages when configuring of cmake.
65fa39b
khangtb1
reviewed
Oct 27, 2023
| ) | ||
|
|
||
| LINK_DIRECTORIES( | ||
| ${WAYLAND_CLIENT_LIBRARY_DIRS} |
There was a problem hiding this comment.
no binaries link to libwayland-client.so, don't need to keep this link
khangtb1
reviewed
Oct 30, 2023
| deinit_ctx_list_content(); | ||
| } | ||
|
|
||
| void init_ctx_list_content() |
There was a problem hiding this comment.
consider to divide this function to sub-functions, for supporting add new surface, seat, layer, and screen. it will be cleaner than currently.
khangtb1
reviewed
Oct 30, 2023
|
|
||
| ASSERT_EQ(1, wl_proxy_marshal_flags_fake.call_count); | ||
| ASSERT_EQ(1, wl_display_roundtrip_queue_fake.call_count); | ||
| ASSERT_EQ(mp_failureResult[0], wl_display_roundtrip_queue_fake.return_val_history[0]); |
There was a problem hiding this comment.
Consider to remove the check the result, that were faked with SET_RETURN_SEQ
|
To make more convenient to review and update, all changes will continue to be updated in PR_180. This PR will be closed. |
|
please just ensure the useful content is also part of #180 and we will continue there.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This folder consists of 3 parts:
Struct of tests:
