New solution for estimate_symbolic_duration #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adressed issue #371
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #372 +/- ##
===========================================
- Coverage 84.11% 82.29% -1.82%
===========================================
Files 82 88 +6
Lines 14506 15463 +957
===========================================
+ Hits 12202 12726 +524
- Misses 2304 2737 +433 ☔ View full report in Codecov by Sentry. |
|
Thank you for the quick fix! I added some minor details to the estimation but I think it works nicely now. Since I added code, feel free to review and merge. |
manoskary
commented
Oct 2, 2024
There was a problem hiding this comment.
The Straight Durs is a nice global that fixes a lot of potential issues, I agree that it is a crucial addition for making the estimation more robust. The last changes by @sildater also include some better styling and more detailed warnings about composite symbolic durations.
fosfrancesco
requested changes
Oct 2, 2024
added comment for global straght_durs.
fosfrancesco
approved these changes
Oct 2, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adressed issue #371
Introduced two new clauses that collapse the prediction to empty symbolic duration to avoid wrong values.