tests: improve expectFailForPaths #46

acl-cqc · 2024-10-25T13:23:45Z

Note: follows #45, but I think this should go as a separate commit into main, so please do not merge if approved.

Move expectFailForPaths from Test/Parsing.hs to Test/Util.hs (I mean, really...)
Move parseAndCheck from Test/Util.hs to Test/Checking.hs (I mean, I think....)
expectFailForPaths checks that all the paths it was expecting to fail did actually exist. Not all of them were, so remove a couple....

… 2 such

…port

mark-koch

Nice, makes sense to move these functions 👍

acl-cqc added 5 commits October 25, 2024 12:55

Tests: error on unused imports

25f1602

Fix Abstractor.hs, WTF

0fea84d

Move expectFailForPaths from Test.Parsing into Test.Util

cd5b7bb

Move parseAndCheck from Test.Util into Test.Checking

ccbeb1e

expectFailForPaths 'error's if any expected paths don't exist; remove…

00627b7

… 2 such

Base automatically changed from tests/error_unused_import to main October 25, 2024 14:24

acl-cqc added 2 commits October 25, 2024 15:24

Merge remote-tracking branch 'origin/main' into tests/error_unused_im…

3b992e6

…port

Merge branch 'tests/error_unused_import' into tests/expect_fail_better

d4afb78

acl-cqc requested a review from mark-koch October 25, 2024 14:26

mark-koch approved these changes Oct 28, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into tests/expect_fail_better

c03cbcb

acl-cqc merged commit cea653c into main Oct 29, 2024
1 check passed

acl-cqc deleted the tests/expect_fail_better branch October 29, 2024 09:45

Provide feedback