Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Common-up in checkBody #57

Merged
merged 3 commits into from
Nov 25, 2024
Merged

[refactor] Common-up in checkBody #57

merged 3 commits into from
Nov 25, 2024

Conversation

acl-cqc
Copy link
Collaborator

@acl-cqc acl-cqc commented Nov 22, 2024

This arose trying to merge #41 with already-on-main #48.

Three commits....

  • the first (pure refactor) just commons up the two makeBox calls. This requires a slightly awkward currying of checkConnectorsUsed in order to preserve exact behaviour (specifically, passing in show tm rather than show (WC fc tm) in the Clauses case).
  • the second changes the Clauses case to show (WC fc tm) rather than show tm, paralleling the NoLhs case (but with a fake FC). However this doesn't actually change the output (changing that to "foo" breaks tests, but this change doesn't), so seems harmless.
  • The third (again, pure refactor) tidies up by inlining now-singly-called checkConnectorsUsed

@acl-cqc acl-cqc requested a review from croyzor November 22, 2024 11:56
@croyzor croyzor merged commit e539073 into main Nov 25, 2024
2 checks passed
@croyzor croyzor deleted the acl/refactor-checkBody branch November 25, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants