clippy fix

Author: lmondada

hugr-persistent/src/commit.rs

@@ -76,7 +76,7 @@ impl<'a> Commit<'a> {
     pub(crate) fn new_base(hugr: Hugr, state_space: &'a CommitStateSpace) -> Self {
         let commit = RelRc::new(CommitData::Base(hugr));
         commit
-            .try_register_in(&state_space.as_registry())
+            .try_register_in(state_space.as_registry())
             .expect("new node is not yet registered");
 
         Commit(commit, PhantomData)
@@ -119,7 +119,7 @@ impl<'a> Commit<'a> {
             return Err(InvalidCommit::NonUniqueBase(err.count()));
         }
 
-        rc.try_register_in(&state_space.as_registry())
+        rc.try_register_in(state_space.as_registry())
             .expect("new node is not yet registered");
 
         Ok(Self(rc, PhantomData))

hugr-persistent/src/commit/boundary.rs

@@ -59,11 +59,11 @@ impl Commit<'_> {
         return_invalid: BoundaryMode,
     ) -> impl Iterator<Item = (PatchNode, IncomingPort)> + '_ {
         assert!(
-            self.has_boundary_edge_into(node, port, &child),
+            self.has_boundary_edge_into(node, port, child),
             "not a boundary edge"
         );
 
-        let parent_hugrs = ParentsView::from_commit(&child);
+        let parent_hugrs = ParentsView::from_commit(child);
         let repl = child.replacement().expect("valid child commit");
         let child_id = child.id();
         repl.linked_replacement_inputs(
@@ -100,7 +100,7 @@ impl Commit<'_> {
         child: &Commit,
         return_invalid: BoundaryMode,
     ) -> Option<(PatchNode, OutgoingPort)> {
-        let parent_hugrs = ParentsView::from_commit(&child);
+        let parent_hugrs = ParentsView::from_commit(child);
         let repl = child.replacement()?;
         match repl.linked_replacement_output(
             (self.to_patch_node(node), port),

hugr-persistent/src/state_space.rs

@@ -103,7 +103,7 @@ impl From<Registry<CommitData, ()>> for CommitStateSpace {
 
 impl From<Rc<RefCell<Registry<CommitData, ()>>>> for CommitStateSpace {
     fn from(registry: Rc<RefCell<Registry<CommitData, ()>>>) -> Self {
-        Self { registry: registry }
+        Self { registry }
     }
 }
 
@@ -114,6 +114,12 @@ impl<'a> From<&'a Rc<RefCell<Registry<CommitData, ()>>>> for &'a CommitStateSpac
     }
 }
 
+impl Default for CommitStateSpace {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl CommitStateSpace {
     /// Create a new empty commit state space.
     pub fn new() -> Self {
@@ -129,7 +135,7 @@ impl CommitStateSpace {
         if !self.registry.borrow().is_empty() {
             return None;
         }
-        Some(Commit::new_base(hugr, &self))
+        Some(Commit::new_base(hugr, self))
     }
 
     /// Check if `commit` is in the commit state space.