Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer extension-deltas for FuncDefn's #1237

Open
acl-cqc opened this issue Jun 28, 2024 · 0 comments
Open

Infer extension-deltas for FuncDefn's #1237

acl-cqc opened this issue Jun 28, 2024 · 0 comments

Comments

@acl-cqc
Copy link
Contributor

acl-cqc commented Jun 28, 2024

We need to decide whether this is really worth it, i.e. is it too painful (and not enough of a good thing anyway) to require FuncDefn authors to declare what extensions they use. But there is at least some utility in that it's optional anyway.

This could be done with the same interface to that for DFGs/CFGs/etc. (using TO_BE_INFERRED: ExtensionId as per #1195), but the algorithm needs to be significantly more complicated:

  • Build a (directed) call graph of functions, each node has a lower-bound ExtensionSet of the non-Call leaf ops
  • Identify cycles - all functions on a cycle must have the same ExtensionSet, so "merge metas" (replace cycle with single node with lower-bound being the union)
  • Solve the unknowns - each is just union over the successors (things it must contain)

This is very roughly what was in old #1137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant