Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling: improve around calls into CodegenExtension #1691

Open
hugrbot opened this issue Nov 25, 2024 · 0 comments
Open

Error handling: improve around calls into CodegenExtension #1691

hugrbot opened this issue Nov 25, 2024 · 0 comments
Labels
llvm Pertains to LLVM emission

Comments

@hugrbot
Copy link
Collaborator

hugrbot commented Nov 25, 2024

Originally raised by @doug-q:

We expect this to be the primary extension point, so there is no excuse for user mistakes to cause panics.

Audit all calls to verify preconditions, and return helpful errors when they are violated.

Suggest trying to use anyhow::Context for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm Pertains to LLVM emission
Projects
None yet
Development

No branches or pull requests

1 participant