Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiblingSubgraph::try_from_nodes should not demand connected outputs in subgraph #1766

Open
ss2165 opened this issue Dec 11, 2024 · 0 comments

Comments

@ss2165
Copy link
Member

ss2165 commented Dec 11, 2024

Currently try_from_nodes expects the nodes in the subgraph to have singly connected outputs, this is too restrictive especially since we use it heavily for constructing rewrites. Rewrites on subrgaphs with discarded or multi-used outputs should be allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant