Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm encoding is not defined on the json schema #1505

Open
aborgna-q opened this issue Jul 30, 2024 · 2 comments
Open

Wasm encoding is not defined on the json schema #1505

aborgna-q opened this issue Jul 30, 2024 · 2 comments
Labels
classical-logic issues related to classical logical expressions

Comments

@aborgna-q
Copy link
Contributor

The wasm field in encoded operations does not appear in the schema.
https://github.com/CQCL/tket/blob/develop/schemas/circuit_v1.json

As @johnchildren mentions in CQCL/tket-json-rs#61 (comment),

Honestly if they aren't too set on the schema yet there are some improvements I'd perhaps like to make such as renaming wasm_file_uid to uid

@aborgna-q aborgna-q changed the title Wasm encoding is not on defined on the json schema Wasm encoding is not defined on the json schema Jul 30, 2024
@CalMacCQ
Copy link
Contributor

Is this issue causing problems for tket-json-rs?

@CalMacCQ CalMacCQ added the classical-logic issues related to classical logical expressions label Sep 16, 2024
@aborgna-q
Copy link
Contributor Author

We merged a definition that "looks to be alright" in CQCL/tket-json-rs#61, but since the source of truth is deep in the cpp code there is no assurance that it is correct nor that it will remain correct.

A schema validation would probably fail too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classical-logic issues related to classical logical expressions
Projects
None yet
Development

No branches or pull requests

2 participants