Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display videos embedded in tweets #200

Open
glciampaglia opened this issue Jun 9, 2023 · 2 comments
Open

Display videos embedded in tweets #200

glciampaglia opened this issue Jun 9, 2023 · 2 comments
Assignees
Labels
backend Issues related to the backend of Rockwell frontend Issues related to the frontend of Rockwell
Milestone

Comments

@glciampaglia
Copy link
Collaborator

A lot of blank tweets with t.co links are actually tweets with embedded video. Instead of remove those tweets, we will include a video playback. This is doable in HTML5 without any additional javascript.

See example here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video

To supply the video, we can point directly to the video asset on the Twitter CDN. For this we need to include the media attachments in the tweet: https://developer.twitter.com/en/docs/twitter-api/data-dictionary/object-model/media

Need to include v2 object in the database [Saumya]

@glciampaglia glciampaglia added frontend Issues related to the frontend of Rockwell backend Issues related to the backend of Rockwell labels Jun 9, 2023
@saumyabhadani95
Copy link
Collaborator

I am storing the v2 object in the database now. Check out the tweet table

@glciampaglia
Copy link
Collaborator Author

glciampaglia commented Jun 30, 2023

We have decided we will not display tweets with video in the "endless feed" pilot, so we need to:

  • Detect that a tweet has video (this info is now in the tweet table)
  • In feedGeneration, Add a conditional that checks if tweet has video, then skip it.
  • When a tweet with video is skipped, log to the console a message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issues related to the backend of Rockwell frontend Issues related to the frontend of Rockwell
Projects
None yet
Development

No branches or pull requests

4 participants