Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement unit tests #195

Open
modernNeo opened this issue Apr 6, 2019 · 4 comments
Open

implement unit tests #195

modernNeo opened this issue Apr 6, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@modernNeo
Copy link
Member

here's a bit of info on how to do it.

Rapptz/discord.py#197

@modernNeo modernNeo added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 6, 2019
@wnfldchen
Copy link
Member

Adding tests has been in the back of my mind for a while. This is exciting.

Yes, I agree with the link that unit tests would involving splitting off the logic into its own functions.

If we ever wanted to do integration/system testing, there might be a way we could mockup by, say, scripting, or, os or network level tricks, but it would be too difficult to maintain.

Also, on the development end, either way we will have to introduce the need to write tests and keep tests up to date.

Id be up for writing unit tests for the existing commands and integrating it with the pipeline, but some of the logic will be quite difficult to test for. We'll see.

@modernNeo
Copy link
Member Author

@wnfldchen my only issue is I wish we could test with context so we could test if stuff like reacting to the image triggers pagination related thing (going back a page and forward a page)

@modernNeo
Copy link
Member Author

also, just an fyi, I have generally worked on all the issue that I opened up but I have neglected work on the website in favor of the bot for too long so this issue will not be worked on by me.

@modernNeo
Copy link
Member Author

using flake8 would help with some formatting for unit tests: grantmcconnaughey/Flake8Rules#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants