Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command to show SFU classes next semester #656

Open
EarthenSky opened this issue Oct 8, 2024 · 2 comments · May be fixed by #666
Open

New command to show SFU classes next semester #656

EarthenSky opened this issue Oct 8, 2024 · 2 comments · May be fixed by #666
Assignees

Comments

@EarthenSky
Copy link

EarthenSky commented Oct 8, 2024

We'd like a new command which gives a summary of all the SFU classes being run next semester, including class names & a short description. This command should enable the user to filter based on the semester (default to next semester), department (default all), and year (default all). You can use whatever parameter syntax you'd like.

ex:

  • display only CMPT classes
  • display only 200 level classes
  • display only MATH 3xx classes in fall 2023

This should extend the approach used in def outline(...) in https://github.com/CSSS/wall_e/blob/master/wall_e/extensions/sfu.py You shouldn't need to modify anything outside this file, except for getting the bot setup locally for testing.

As always, if you have any questions about this issue please feel free to ask me! (or if you have any questions about setup, please reach out to Jace)

Bonus If you'd like, I'd appreciate if you can clean up the code style of module, as outline definitely needs to be more dry

@chanchantang
Copy link

To clarify, is this a completely new command to be created using the logic of def outline(...), or will it be adding to the existing .outline command?

@EarthenSky
Copy link
Author

EarthenSky commented Oct 11, 2024

To clarify, is this a completely new command to be created using the logic of def outline(...), or will it be adding to the existing .outline command?

I think it should be a completely new command

Originally I mentioned this should extend outline because I was thinking about where we'd retrieve the course info data. outline essentially just does a fetch using sfu's public course outline API.

Though looking into it a bit deeper, it's possible it doesn't completely solve our problem. https://www.sfu.ca/bin/wcm/course-outlines?2019/fall/CMPT gives essentially what we want for just CMPT courses, but not if we wanted to include all departments; in that case we'd have to make multiple requests... Maybe we should update the interface to only allow for a few?

Feel free to choose whatever seems most reasonable!

chanchantang added a commit to chanchantang/wall_e that referenced this issue Oct 13, 2024
chanchantang added a commit to chanchantang/wall_e that referenced this issue Oct 13, 2024
@EarthenSky EarthenSky linked a pull request Oct 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants