Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner references old newsletter #438

Closed
MattyTheHacker opened this issue Jul 17, 2023 · 2 comments · Fixed by #631
Closed

Banner references old newsletter #438

MattyTheHacker opened this issue Jul 17, 2023 · 2 comments · Fixed by #631

Comments

@MattyTheHacker
Copy link
Member

https://cssbham.com/newsletter/looking-back-at-2022-23

The banner at the top of this page references the newsletter from 2021

@Thatsmusic99
Copy link
Member

Caused by these lines:

<div id="freshers-banner">
<p>Joining us in September? Read our <a href=/newsletter/freshers-welcome-2021>2021 Welcome Newsletter</a> and <a href=/discord>meet everyone else over on the Discord</a></p>
</div>

Can probably comment out for the month then re-introduce it for results day with the updated newsletter.

@AlexJBanks
Copy link
Member

For context, this was meant to be a temporary solution to drive more traffic to the intro page that year [#146], with the intention to delete it from the source code after Freshers 2021.

That then changed into a desire to keep the banner long term (as it was successful), but refactor the code to make it easier to change the content of the banner and if it was even displayed in the first place [part of #153]. So a temporary solution was used to hide the banner and come back to it later. [#152 #180]

The banner is technically 2 separate instances, one in /_layouts/post.html and one in /_layouts/page.html. It should be revised to one piece of code that performs the same function across both pages, and can be maintained from one place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants