Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#149 Update Constitution links and pdf #166

Merged
merged 6 commits into from
Sep 6, 2021

Conversation

sapphyree
Copy link
Contributor

Update CSS Constitution file and clean up links on about as well as adding a /constitution redirect so it can be directly used instead of using /constitution.pdf. Closes #149.

Copy link
Member

@AlexJBanks AlexJBanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that there's only one link to our Constitution now, can the Constitution section of /about section be reworded to

That means we've got a constitution that you can read here. We recommend that all our members read it at least once.

@sapphyree
Copy link
Contributor Author

Given that there's only one link to our Constitution now, can the Constitution section of /about section be reworded to

That means we've got a constitution that you can read here. We recommend that all our members read it at least once.

I'm not entirely sure I agree with this. Part of me prefers the fact that it's sectioned off and very clearly visible. It being a hyperlink in a sentence feels to me like it'll be ignored by those reading over the about section.

I can do this if you're absolutely sure, though. Perhaps there's another solution as well?

@LikkanChung
Copy link
Member

Given that there's only one link to our Constitution now, can the Constitution section of /about section be reworded to

That means we've got a constitution that you can read here. We recommend that all our members read it at least once.

I'm not entirely sure I agree with this. Part of me prefers the fact that it's sectioned off and very clearly visible. It being a hyperlink in a sentence feels to me like it'll be ignored by those reading over the about section.

I can do this if you're absolutely sure, though. Perhaps there's another solution as well?

I don't think it matters either way

@Danyc0
Copy link
Member

Danyc0 commented Sep 5, 2021

i agree with @sapphyree, it's nice that it's made obvious and clearly visible by being in its own section

@AlexJBanks
Copy link
Member

AlexJBanks commented Sep 5, 2021

Can we find a suitable compromise then, at the moment I'm not that happy with it just being a link on a single bullet point looking a bit sad on its own.

Screenshot_20210905-134229.png

Could we turn the Constitution and Agendas links into buttons?

@Jack-Development
Copy link
Contributor

We coud potenitally change the text to read like "Here is our constitution and agendas for you to read" and reuse the styles of the buttons higher up?

<p>We recommend that all our members read it at least once. </p>
<p> You can also find our agendas <a href=/agendas">here</a>. </p>
<div id="constitution">
<div class="flex-container flex-v-center">
Copy link
Member

@AlexJBanks AlexJBanks Sep 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these divs are probably redundant but can be tidyied up in #153

@AlexJBanks AlexJBanks merged commit 5dcfec6 into CSSUoB:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated consitution
5 participants