Skip to content
This repository has been archived by the owner on Sep 15, 2024. It is now read-only.

Optimizing Coin.cs #120

Open
valkyrienyanko opened this issue Jun 1, 2022 · 0 comments
Open

Optimizing Coin.cs #120

valkyrienyanko opened this issue Jun 1, 2022 · 0 comments
Labels
help wanted Extra attention is needed low priority This issue is not that important. old This issue hasnt been touched in a while question Further information is requested

Comments

@valkyrienyanko
Copy link
Collaborator

valkyrienyanko commented Jun 1, 2022 •
edited
Loading

Checking if (!_movingToPlayer || _jumpingOutOfChest) and if (!_jumpingOutOfChest) every frame of _PhysicsProcess seems unnecessary. There is most likely a more optimized approach to this.

https://github.com/GodotModules/GodotModulesCSharp/blob/52b34211535f49e611032aecfc38a19ae96d8eb6/Scripts/Game/Coin.cs#L17-L63
@valkyrienyanko valkyrienyanko added help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Jun 1, 2022
@valkyrienyanko valkyrienyanko removed the good first issue Good for newcomers label Jun 28, 2022
@valkyrienyanko valkyrienyanko added the old This issue hasnt been touched in a while label Jul 17, 2022
@valkyrienyanko valkyrienyanko added the low priority This issue is not that important. label Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Extra attention is needed low priority This issue is not that important. old This issue hasnt been touched in a while question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@valkyrienyanko