Skip to content

Bug in SP without weights #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luethen opened this issue Oct 20, 2020 · 0 comments
Open

Bug in SP without weights #1

luethen opened this issue Oct 20, 2020 · 0 comments

Comments

@luethen
Copy link

luethen commented Oct 20, 2020

Hi Paul,

Thanks a lot for your code, I have been using it quite a lot for my research and in general, it works very well. Unfortunately, I recently noticed a bug in SP.m: in line 22ff, even if the fourth argument weight is set to false, the if-condition will enter the else and normalize Psi. I guess adding || ~weight to the condition in line 22 would be enough to fix it.

Best,
Nora

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant