From 6482ed6a9fa8940e43912d738fc8f93e30a76789 Mon Sep 17 00:00:00 2001 From: Zack Malkmus <112013308+zmalkmus@users.noreply.github.com> Date: Fri, 7 Jun 2024 15:42:59 -0400 Subject: [PATCH] disable pip publishing After testing, (and realizing something I should have known at the start), pip cannot package non-python files such as .html or .js files. so when publishing and installing this as a package, none of those files are included, and thus, the application is not able to run. It only works on systems that have installed agvis through github. Therefore, pip is pretty much useless with AGVis, and conda would be a better place to handle such publishing tasks. --- .github/workflows/pythonapp.yml | 78 +++++++++++++++++---------------- 1 file changed, 40 insertions(+), 38 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index b91afba..6477167 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -12,15 +12,16 @@ jobs: uses: actions/setup-python@v5 with: python-version: "3.8" - - name: Install pypa/build and twine - run: python3 -m pip install build twine setuptools_scm - - name: Build a binary wheel and a source tarball - run: python3 -m build - - name: Store the distribution packages - uses: actions/upload-artifact@v4 - with: - name: python-package-distributions - path: dist/ + # PIP BUILD + # - name: Install pypa/build and twine + # run: python3 -m pip install build twine setuptools_scm + # - name: Build a binary wheel and a source tarball + # run: python3 -m build + # - name: Store the distribution packages + # uses: actions/upload-artifact@v4 + # with: + # name: python-package-distributions + # path: dist/ test: name: Run test suite @@ -41,32 +42,33 @@ jobs: # pip install flake8 # specify flake8 to avoid unknown error # # stop the build if there are Python syntax errors or undefined names # flake8 . - - publish-to-pypi: - name: Publish Python distribution to PyPI - if: github.ref == 'refs/heads/master' && github.event_name == 'push' - needs: - - build - - test - runs-on: ubuntu-latest - steps: - - name: Checkout code - uses: actions/checkout@v4 - - name: Set up Python - uses: actions/setup-python@v5 - with: - python-version: "3.8" - - name: Install twine - run: pip install twine - - name: Download distribution packages - uses: actions/download-artifact@v4 - with: - name: python-package-distributions - path: dist/ - - name: Check dist/ - run: twine check dist/* - - name: Publish Python dist to PyPI - run: twine upload dist/* - env: - TWINE_USERNAME: __token__ - TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }} \ No newline at end of file + + # PIP PUBLISH + # publish-to-pypi: + # name: Publish Python distribution to PyPI + # if: github.ref == 'refs/heads/master' && github.event_name == 'push' + # needs: + # - build + # - test + # runs-on: ubuntu-latest + # steps: + # - name: Checkout code + # uses: actions/checkout@v4 + # - name: Set up Python + # uses: actions/setup-python@v5 + # with: + # python-version: "3.8" + # - name: Install twine + # run: pip install twine + # - name: Download distribution packages + # uses: actions/download-artifact@v4 + # with: + # name: python-package-distributions + # path: dist/ + # - name: Check dist/ + # run: twine check dist/* + # - name: Publish Python dist to PyPI + # run: twine upload dist/* + # env: + # TWINE_USERNAME: __token__ + TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}