Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released sources from here https://github.com/CadQuery/OCP/releases do not require editing AFAICT, no need to use conda to compile them. #115

Open
ragdenesie opened this issue Jul 17, 2023 · 2 comments

Comments

@ragdenesie
Copy link

          Released sources from here https://github.com/CadQuery/OCP/releases do not require editing AFAICT, no need to use conda to compile them.

Originally posted by @adam-urbanczyk in CadQuery/pywrap#49 (comment)

@ragdenesie
Copy link
Author

Hi there,
In the meanwhile I succeeded to compile the 7.7.0.1 OCP source, and it worked out of the box by 99.99%.
Only one minor issue appears to be in ChFi3d.cpp. Actually, the "IsTangentFaces_s" is somehow duplicated and the second one does not exist in the definition of "ChFi3d.hxx".
However how the second definition is produced, I simply commented for the moment

     .def_static("IsTangentFaces_s",
                (Standard_Boolean (*)( const TopoDS_Edge & ,  const TopoDS_Face & ,  const TopoDS_Face & ,  const GeomAbs_Shape  ) ) static_cast<Standard_Boolean (*)( const TopoDS_Edge & ,  const TopoDS_Face & ,  const TopoDS_Face & ,  const GeomAbs_Shape  ) >(&ChFi3d::IsTangentFaces),
                R"#(Returns true if theEdge between theFace1 and theFace2 is tangent)#"  , py::arg("theEdge"),  py::arg("theFace1"),  py::arg("theFace2"),  py::arg("Order")=static_cast<const GeomAbs_Shape>(GeomAbs_G1)
      )

	  /*
    .def_static("IsTangentFaces_s",
                (Standard_Boolean (*)( const TopoDS_Edge & ,  const TopoDS_Face & ,  const TopoDS_Face & ,  Standard_Real ,  const GeomAbs_Shape  ) ) static_cast<Standard_Boolean (*)( const TopoDS_Edge & ,  const TopoDS_Face & ,  const TopoDS_Face & ,  Standard_Real ,  const GeomAbs_Shape  ) >(&ChFi3d::IsTangentFaces),
                R"#(None)#"  , py::arg("theEdge"),  py::arg("theFace1"),  py::arg("theFace2"),  py::arg("G1Tol"),  py::arg("Order")=static_cast<const GeomAbs_Shape>(GeomAbs_G1)
      )
      */

From the hxx the only statement is the first one

//! Returns true if theEdge between theFace1 and theFace2 is tangent
Standard_EXPORT static Standard_Boolean IsTangentFaces (const TopoDS_Edge& theEdge,
                                                      const TopoDS_Face& theFace1,
                                                      const TopoDS_Face& theFace2,
                                                      const GeomAbs_Shape Order = GeomAbs_G1); 

@ragdenesie
Copy link
Author

closed by accident

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant