Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create generic comment system #14

Open
v-pan opened this issue Mar 2, 2019 · 2 comments
Open

Create generic comment system #14

v-pan opened this issue Mar 2, 2019 · 2 comments
Assignees
@ericm

Comments

@v-pan
Copy link
Collaborator

v-pan commented Mar 2, 2019

The Firestore DB has no storage of comments, which means we cannot implement the design standard.
@CaelumF CaelumF mentioned this issue Mar 23, 2019
Open
18 tasks
@v-pan
Copy link
Collaborator Author

v-pan commented Mar 23, 2019

The Firestore also needs to include entries for #9's challenge component + discussion section

@CaelumF CaelumF changed the title Comments are currently non-existant within the Firestore DB Create generic comment system Mar 30, 2019
@CaelumF
Copy link
Owner

CaelumF commented Mar 30, 2019 •
edited by ericm
Loading

  • No unnecessary queries
  • No querying entire sets of comments

@ericm ericm mentioned this issue Mar 30, 2019
Merged
ericm added a commit that referenced this issue Mar 30, 2019
@ericm
Added Comments Query (from firebase)for Issues
5068187 
See Issue #14
@ericm ericm mentioned this issue Mar 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericm ericm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CaelumF @ericm @v-pan