Reviewed 11 of 14 files at r1, all commit messages.
Reviewable status: 11 of 14 files reviewed, 6 unresolved discussions (waiting on @Alex-NRCan, @DamonU2, and @MatthewMuehlhauserNRCan)

packages/geoview-core/public/locales/en/translation.json line 229 at r1 (raw file):

    "noTab": "No tab"
  }
}

Why does your prettier did this. There a config you have and who is not in the repo. Same for next translation file

packages/geoview-core/src/core/utils/config/config.ts line 65 at r1 (raw file):

          this.#setLayerEntryType(
            geoViewLayerEntryCasted.listOfLayerEntryConfig!,
            geoViewLayerEntryCasted.geoviewLayerType as TypeGeoviewLayerType

Why do we need to cast the type now

packages/geoview-core/src/geo/map/map-viewer.ts line 1252 at r1 (raw file):

   * @param {boolean} maintainGeocoreLayerNames - Indicates if geocore layer names should be kept as is or returned to defaults.
   */
  reloadWithCurrentState(maintainGeocoreLayerNames: boolean = true): void {

Is this parameter mostly valid for language change? If the reload state stays in the same language it would always be true? Should we rename the param to reflect or add comment in the JSDOC

packages/geoview-core/src/geo/map/map-schema-types.ts line 374 at r1 (raw file):

  metadataAccessPath?: string;
  /** Type of GeoView layer. */
  geoviewLayerType: 'geoCore' | TypeGeoviewLayerType;

We should not modify the map-schema type in geo. We should use as much as we could the one in config. This one is deprecated. In new config there is flag to know if it is geocore originally ( "isGeocore": true,). Should we use same approach?

packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 33 at r1 (raw file):

import { TypeGeoviewLayerType, TypeOutfieldsType } from '@/api/config/types/map-schema-types';

const translations = {

Translation should be in translation file and we use the getLocalizedMessage function in utilities warning AND like you did with showError but look at how it is done with other error were parameter are pass to the function (i.e. wrongPath)

packages/geoview-core/src/geo/layer/other/geocore.ts line 59 at r1 (raw file):

        tempLayerConfig.metadataAccessPath = response.layers[0].metadataAccessPath;
        tempLayerConfig.geoviewLayerType = response.layers[0].geoviewLayerType;
        if (!tempLayerConfig.geoviewLayerName) tempLayerConfig.geoviewLayerName = response.layers[0].geoviewLayerName;

Can you add a comment why you do this if

Reviewed 3 of 14 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @Alex-NRCan and @DamonU2)

Reviewable status: 10 of 14 files reviewed, 6 unresolved discussions (waiting on @Alex-NRCan, @jolevesq, and @MatthewMuehlhauserNRCan)

packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 33 at r1 (raw file):

Done.

packages/geoview-core/src/geo/layer/other/geocore.ts line 59 at r1 (raw file):

Done.

packages/geoview-core/src/geo/map/map-schema-types.ts line 374 at r1 (raw file):

It's deprecated but we still need the types until the config is handling this.

packages/geoview-core/src/core/utils/config/config.ts line 65 at r1 (raw file):

I changed how I was handling the config so this is no longer needed. Removed.

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @Alex-NRCan and @jolevesq)

Reviewable status: 13 of 18 files reviewed, 6 unresolved discussions (waiting on @Alex-NRCan, @jolevesq, and @MatthewMuehlhauserNRCan)

packages/geoview-core/src/geo/map/map-viewer.ts line 1252 at r1 (raw file):

Done.