Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate command line argument to force a random password #15

Open
hexmode opened this issue Sep 4, 2022 · 1 comment
Open

Separate command line argument to force a random password #15

hexmode opened this issue Sep 4, 2022 · 1 comment

Comments

@hexmode
Copy link
Contributor

hexmode commented Sep 4, 2022

Currently, there only way to avoid prompts when running canasta create is to set the password the an empty value on the command line. I prefer making this explicit by adding a -r to the options so that we leave open the possibility of someone providing an empty password in the future.

Even if the decision is made to not allow empty passwords, explicitly requesting the creation of a random password is better than the implied behavior of creating a random password when you are given a blank one. (Note that I'm not addressing the interactive dialog where the user is explicitly told a random password will be created if an empty line is provided.)

hexmode added a commit to hexmode/Canasta-CLI that referenced this issue Sep 4, 2022
@amalpaul54111
Copy link
Collaborator

This looks great and works, Thank You. I guess this could be merged.
What do you think @jeffw16 ?

hexmode added a commit to hexmode/Canasta-CLI that referenced this issue Sep 13, 2022
hexmode added a commit to hexmode/Canasta-CLI that referenced this issue Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants