Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC-003] Namespace segregation #37

Open
TheCurle opened this issue Aug 18, 2024 · 4 comments
Open

[RFC-003] Namespace segregation #37

TheCurle opened this issue Aug 18, 2024 · 4 comments
Assignees
Labels
RFC Request for Comments

Comments

@TheCurle
Copy link
Member

I feel like using the SH namespace (as per RFC-001, which I remain in favor of) for all engine provided tools is rather restrictive.

It leads to situations where code utilities like the event manager, module system, timer, etc are in the same namespace as game-world functions like the scene, components, entities, systems...

I feel like we should have a namespace for game-world, separate from SH.

Perhaps something like SW, standing for Shadow World?

@TheCurle TheCurle added the RFC Request for Comments label Aug 18, 2024
@dpeter99
Copy link
Member

What would you put in the SW namespace?
The actual entity components like:
SW::PointLight and SW::Mesh ?

@TheCurle
Copy link
Member Author

In short, things that can affect the actual game scene. SW::Scene, SW::Light, SW::Entity, SW::Component, SW::Model.

@dpeter99
Copy link
Member

Sure I can look into refactoring those, might make some of the entity code a bit more spread out over 2 namespaces tho...
I'll put that into the V3 of the ECS

@TheCurle
Copy link
Member Author

I think there's not much entity code that won't be in the new namespace; if the whole ECS module is in SW namespace, it should be really self contained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request for Comments
Projects
None yet
Development

No branches or pull requests

2 participants