add OTHERS error code

Canner · Jul 15, 2024 · e0a2ae9 · e0a2ae9
1 parent 04456eb
commit e0a2ae9
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/wren-ai-service/src/web/v1/services/ask.py b/wren-ai-service/src/web/v1/services/ask.py
@@ -27,8 +27,12 @@ class SemanticsPreparationStatusRequest(BaseModel):
 
 
 class SemanticsPreparationStatusResponse(BaseModel):
+    class SemanticsPreparationError(BaseModel):
+        code: Literal["OTHERS"]
+        message: str
+
     status: Literal["indexing", "finished", "failed"]
-    error: Optional[str] = None
+    error: Optional[SemanticsPreparationError] = None
 
 
 class SQLExplanation(BaseModel):
@@ -151,7 +155,10 @@ def get_prepare_semantics_status(
             )
             return SemanticsPreparationStatusResponse(
                 status="failed",
-                error=f"{prepare_semantics_status_request.id} is not found",
+                error=SemanticsPreparationStatusResponse.SemanticsPreparationError(
+                    code="OTHERS",
+                    message="{prepare_semantics_status_request.id} is not found",
+                ),
             )
 
         return result

diff --git a/wren-ai-service/src/web/v1/services/sql_explanation.py b/wren-ai-service/src/web/v1/services/sql_explanation.py
@@ -40,9 +40,13 @@ class SQLExplanationResultRequest(BaseModel):
 
 
 class SQLExplanationResultResponse(BaseModel):
+    class SQLExplanationResultError(BaseModel):
+        code: Literal["OTHERS"]
+        message: str
+
     status: Literal["understanding", "generating", "finished", "failed"]
     response: Optional[List[List[Dict]]] = None
-    error: Optional[str] = None
+    error: Optional[SQLExplanationResultError] = None
 
 
 class SQLExplanationService:
@@ -100,7 +104,10 @@ async def _task(
                 sql_explanation_request.query_id
             ] = SQLExplanationResultResponse(
                 status="failed",
-                error=str(e),
+                error=SQLExplanationResultResponse.SQLExplanationResultError(
+                    code="OTHERS",
+                    message=str(e),
+                ),
             )
 
     def get_sql_explanation_result(