From b1a0122797a493a89fc2980d8253b943bdfe5018 Mon Sep 17 00:00:00 2001 From: Grieve Date: Wed, 12 Jun 2024 14:19:42 +0800 Subject: [PATCH] Fix needs --- .github/workflows/ibis-ci.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ibis-ci.yml b/.github/workflows/ibis-ci.yml index 254b153c1..0eebfd2e0 100644 --- a/.github/workflows/ibis-ci.yml +++ b/.github/workflows/ibis-ci.yml @@ -71,7 +71,8 @@ jobs: docker compose --env-file .env up -d ci: runs-on: ubuntu-latest - needs: [ruff-check, java-engine] + needs: [ ruff-check, build-java-and-run-engine, run-latest-docker-image ] + if: always() && (needs.ruff-check.result == 'success' && (needs.build-java-and-run-engine.result == 'success' || needs.run-latest-docker-image.result == 'success')) steps: - uses: actions/checkout@v4 - name: Install poetry @@ -87,14 +88,14 @@ jobs: WREN_ENGINE_ENDPOINT: http://localhost:8080 run: poetry run pytest -m "not bigquery and not snowflake" - name: Test bigquery if need - if : contains(github.event.pull_request.labels.*.name, 'bigquery') + if: contains(github.event.pull_request.labels.*.name, 'bigquery') env: WREN_ENGINE_ENDPOINT: http://localhost:8080 TEST_BIG_QUERY_PROJECT_ID: ${{ secrets.TEST_BIG_QUERY_PROJECT_ID }} TEST_BIG_QUERY_CREDENTIALS_BASE64_JSON: ${{ secrets.TEST_BIG_QUERY_CREDENTIALS_BASE64_JSON }} run: poetry run pytest -m bigquery - name: Test snowflake if need - if : contains(github.event.pull_request.labels.*.name, 'snowflake') + if: contains(github.event.pull_request.labels.*.name, 'snowflake') env: WREN_ENGINE_ENDPOINT: http://localhost:8080 SNOWFLAKE_USER: ${{ secrets.SNOWFLAKE_USER }}