Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(image): fix missing sha tag #903

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

grieve54706
Copy link
Contributor

@grieve54706 grieve54706 commented Nov 13, 2024

We found the sha tag missing. Because we cover the text by > when writing to the tags.txt, it should be >> to append it.

I also found an entry type=schedule that can delegate nightly.
https://github.com/docker/metadata-action?tab=readme-ov-file#typeschedule

they are same out, but schedule is feature of docker/metadata-action
@grieve54706 grieve54706 added this to the 0.11.3 milestone Nov 13, 2024
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grieve54706 for fixing it.

@goldmedal goldmedal merged commit 38e04f8 into main Nov 13, 2024
9 checks passed
@goldmedal goldmedal deleted the chore/fix-ci-nightly-lose-amd64 branch November 13, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants