Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support to define param_names and param_types in the list file #925

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat(core): support to define param_names and param_types in the list file #925

merged 1 commit into from
Nov 19, 2024

Conversation

goldmedal
Copy link
Contributor

Description

Because the CSV doesn't support the native array format, use a comma-separated string to present the list.

Sample

function_type,name,return_type,param_names,param_types,description
scalar,add_two,int,"f1,f2","int,int","Adds two numbers together."

@github-actions github-actions bot added the python Pull requests that update Python code label Nov 19, 2024
@goldmedal goldmedal mentioned this pull request Nov 19, 2024
Merged
@goldmedal goldmedal marked this pull request as ready for review November 19, 2024 10:38
grieve54706
grieve54706 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @goldmedal.

@grieve54706 grieve54706 merged commit b50b357 into Canner:main Nov 19, 2024
5 checks passed
@goldmedal goldmedal deleted the feature/def-param-info branch November 20, 2024 02:17
@grieve54706 grieve54706 added this to the 0.12.1 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grieve54706 grieve54706 grieve54706 approved these changes

Assignees
No one assigned
Labels
python Pull requests that update Python code
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@goldmedal @grieve54706