Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): make aggregate functions and window functions support zero argument #943

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix(core): make aggregate functions and window functions support zero argument #943

merged 1 commit into from
Nov 26, 2024

Conversation

grieve54706
Copy link
Contributor

Resolve #924

@grieve54706 grieve54706 added this to the 0.12.3 milestone Nov 25, 2024
@github-actions github-actions bot added core rust Pull requests that update Rust code labels Nov 25, 2024
goldmedal
goldmedal approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grieve54706 LGTM

@goldmedal goldmedal merged commit 90082c7 into main Nov 26, 2024
16 checks passed
@goldmedal goldmedal deleted the bugfix/register-window-function branch November 26, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldmedal goldmedal goldmedal approved these changes

Assignees
No one assigned
Labels
core rust Pull requests that update Rust code
Projects
None yet
Milestone
0.12.3
Development

Successfully merging this pull request may close these issues.

Wren core transform SQL failed Error during planning: cume_dist does not support zero arguments
2 participants
@grieve54706 @goldmedal