test(trino): test all functions #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ibis
trino
python
goldmedal
reviewed
Nov 27, 2024
| aggregate,array_agg,array,,any,Aggregates values into array | ||
| aggregate,avg,double,,numeric,Returns average of values | ||
| aggregate,count,bigint,,any,Counts number of rows | ||
| aggregate,max,same as input,,any,Returns maximum value |
There was a problem hiding this comment.
Suggested change
| aggregate,max,same as input,,any,Returns maximum value | |
| aggregate,max,same as input,,any,Returns maximum value |
Similar issue. I think we can remove them.
goldmedal
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Thanks @grieve54706 there is a conflict. I think you can feel free to merge it after fix the conlfict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a test case and moved out some functions that need to be revised.
#953