Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a listing should open up a pane directly below the listing in question #175

Open
JSlote opened this issue Sep 6, 2016 · 7 comments
Assignees
Milestone

Comments

@JSlote
Copy link
Member

JSlote commented Sep 6, 2016

when a user has listed a lot of books, it's not clear that clicking "edit" does anything

@JSlote JSlote added this to the v3 milestone Sep 6, 2016
@taoduo
Copy link

taoduo commented Sep 6, 2016

I think I can fix this one.

@taoduo taoduo self-assigned this Sep 6, 2016
@JSlote
Copy link
Member Author

JSlote commented Sep 6, 2016

Go ahead and take a stab at it! Another option would be to set a max-height on the tbody like I did in the user's watchlist. (Go and watch a bunch of books and you'll see what I mean)

@taoduo
Copy link

taoduo commented Sep 6, 2016

Aha, I see. I will set the max-height.

@JSlote
Copy link
Member Author

JSlote commented Sep 6, 2016

Yet another option would be to auto-scroll the user down to the bottom :)

@taoduo
Copy link

taoduo commented Sep 8, 2016

Hey @JSlote, I have been struggling hard with this today, and I honestly did not figure out how to do this. I messed up a lot. It involves things I seldom touched such as the CSS. I guess you might have a solution but I will watch.

@taoduo
Copy link

taoduo commented Sep 8, 2016

Hey @JSlote I cleared up my mind this morning, and I think I fixed it.

@taoduo
Copy link

taoduo commented Sep 8, 2016

Another similar issue I notice is that when there are many listing for a book, the list of the book details page will be long. However, currently, the edit pane shows up at the bottom of the list, so if the list is too long, the pane at the bottom will not be immediately visible to the user. It would seem like nothing works.

So what about do the same thing to book detail listings, i.e., showing the edit pane immediately under the listing clicked? However, in this case, I have no idea about what to do for the edit listing button in the table foot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants