Skip to content

Commit

Permalink
🚧 Corrected Typo's From 1.1.1
Browse files Browse the repository at this point in the history
- Corrected a few typos from the refactor & updated the documentation stored in the asset to have said corrections.
  • Loading branch information
JonathanMCarter committed Mar 30, 2023
1 parent d80528a commit cc00c4b
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 19 deletions.
4 changes: 2 additions & 2 deletions Editor/Custom Inspectors/BuildVersionsOptionsEditor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ private void OnEnable()

assetStatus = serializedObject.FindProperty("assetStatus");
buildUpdateTime = serializedObject.FindProperty("buildUpdateTime");
updatePlayerSettingsVersion = serializedObject.FindProperty("updatesemantic");
lastBuildNumber = serializedObject.FindProperty("lastsemanticNumber");
updatePlayerSettingsVersion = serializedObject.FindProperty("updateSemantic");
lastBuildNumber = serializedObject.FindProperty("lastSemanticNumber");
androidCodeSetting = serializedObject.FindProperty("androidUpdateBundleCode");

defaultTextColor = GUI.color;
Expand Down
2 changes: 1 addition & 1 deletion Editor/Updaters/SemanticVersionUpdater.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public void OnPreBuildDialogue(BuildTarget target)
var currentSemantic = GetVersionNumber(target, false);
var updateSemantic = GetVersionNumber(target, true);

var choice = EditorUtility.DisplayDialog("Build Versions | semantic Version Updater",
var choice = EditorUtility.DisplayDialog("Build Versions | Semantic Version Updater",
$"Do you want to increment the semantic version number for this build?\n\nThe version will update from {currentSemantic} to {updateSemantic}.\n\nYou can disable this prompt in the asset settings.",
$"Yes (Set to {updateSemantic})", $"No (Leave as {currentSemantic})");

Expand Down
2 changes: 1 addition & 1 deletion Runtime/Assets/BuildInformation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public int BuildNumber
/// <summary>
/// Get the current version number
/// </summary>
public string semanticVersionNumber => Application.version;
public string SemanticVersionNumber => Application.version;


/// <summary>
Expand Down
30 changes: 15 additions & 15 deletions Runtime/Information Display/BuildInformationDisplay.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ public abstract class BuildInformationDisplay : MonoBehaviour
private const string DayString = "bv_day";
private const string MonthString = "bv_month";
private const string YearString = "bv_year";
private const string semanticString = "bv_semantic";
private const string semanticPatchString = "bv_semantic_patch";
private const string semanticMinorString = "bv_semantic_minor";
private const string semanticMajorString = "bv_semantic_major";
private const string SemanticString = "bv_semantic";
private const string SemanticPatchString = "bv_semantic_patch";
private const string SemanticMinorString = "bv_semantic_minor";
private const string SemanticMajorString = "bv_semantic_major";
private const string NewLine = "newline";


Expand Down Expand Up @@ -137,42 +137,42 @@ protected string Parse(string toParse)

builder.Append(buildInformation.BuildDate.Split('/')[2]);
break;
case semanticString:
builder.Append(buildInformation.semanticVersionNumber);
case SemanticString:
builder.Append(buildInformation.SemanticVersionNumber);
break;
case semanticPatchString:
case SemanticPatchString:

split = buildInformation.semanticVersionNumber.Split('.');
split = buildInformation.SemanticVersionNumber.Split('.');

if (split.Length < 3)
{
BvLog.Warning("Unable to display patch of the semantic versioning number as it does not exist.");
break;
}

builder.Append(buildInformation.semanticVersionNumber.Split('.')[2]);
builder.Append(buildInformation.SemanticVersionNumber.Split('.')[2]);
break;
case semanticMinorString:
case SemanticMinorString:

split = buildInformation.semanticVersionNumber.Split('.');
split = buildInformation.SemanticVersionNumber.Split('.');
if (split.Length < 2)
{
BvLog.Warning("Unable to display minor of the semantic versioning number as it does not exist.");
break;
}

builder.Append(buildInformation.semanticVersionNumber.Split('.')[1]);
builder.Append(buildInformation.SemanticVersionNumber.Split('.')[1]);
break;
case semanticMajorString:
case SemanticMajorString:

split = buildInformation.semanticVersionNumber.Split('.');
split = buildInformation.SemanticVersionNumber.Split('.');
if (split.Equals(string.Empty))
{
BvLog.Warning("Unable to display major of the semantic versioning number as it does not exist.");
break;
}

builder.Append(buildInformation.semanticVersionNumber.Split('.')[0]);
builder.Append(buildInformation.SemanticVersionNumber.Split('.')[0]);
break;
case NewLine:
builder.AppendLine();
Expand Down
Binary file modified ~Documentation/Build Versions Documentation (Offline).pdf
Binary file not shown.

0 comments on commit cc00c4b

Please sign in to comment.