Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working - would love a fix. Thanks! #37

Open
name01019 opened this issue Jul 23, 2022 · 11 comments
Open

Not working - would love a fix. Thanks! #37

name01019 opened this issue Jul 23, 2022 · 11 comments

Comments

@name01019
Copy link

name01019 commented Jul 23, 2022

@Cartmanishere
Thank you for this amazing script. It seems to not be working currently

[*] Using JSEngine for generating links

PyJs_anonymous_1_

PyJs_anonymous_3_
Traceback (most recent call last):
File "zippyshare.py", line 144, in
links, fails = zippy.parse_links(urls)
File "zippyshare.py", line 68, in parse_links
extract, link = f.result()
File "/usr/lib/python3.7/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
File "/usr/lib/python3.7/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "zippyshare.py", line 33, in get_download_link
extract, link = self.engine.get_download_link(link)
File "/media/zippyshare-scraper-master/engines/js.py", line 88, in get_download_link
self.run_js(code)
File "/media/zippyshare-scraper-master/engines/js.py", line 59, in run_js
self.context.execute(code)
File "/home/.local/lib/python3.7/site-packages/js2py/evaljs.py", line 199, in execute
exec (compiled, self._context)
File "", line 23, in
File "/home/.local/lib/python3.7/site-packages/js2py/base.py", line 995, in callprop
cand.typeof(), repr(prop), repr(self.Class)))
js2py.internals.simplex.JsException: TypeError: 'undefined' is not a function (tried calling property 'getAttribute' of 'Object')

@name01019
Copy link
Author

@Cartmanishere

Bump

@Cartmanishere
Copy link
Owner

Cartmanishere commented Jul 29, 2022 via email

@redx113
Copy link

redx113 commented Aug 3, 2022

D:\zippyshare-scraper-master>python zippyshare.py --in-file input_links.txt --out-file outlinks.txt
[*] Using JSEngine for generating links
Traceback (most recent call last):
File "D:\zippyshare-scraper-master\zippyshare.py", line 144, in
links, fails = zippy.parse_links(urls)
File "D:\zippyshare-scraper-master\zippyshare.py", line 68, in parse_links
extract, link = f.result()
File "C:\Program Files\Python310\lib\concurrent\futures_base.py", line 439, in result
return self.__get_result()
File "C:\Program Files\Python310\lib\concurrent\futures_base.py", line 391, in __get_result
raise self._exception
File "C:\Program Files\Python310\lib\concurrent\futures\thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "D:\zippyshare-scraper-master\zippyshare.py", line 33, in get_download_link
extract, link = self.engine.get_download_link(link)
File "D:\zippyshare-scraper-master\engines\js.py", line 88, in get_download_link
self.run_js(code)
File "D:\zippyshare-scraper-master\engines\js.py", line 59, in run_js
self.context.execute(code)
File "C:\Users\Admin\AppData\Roaming\Python\Python310\site-packages\js2py\evaljs.py", line 199, in execute
exec (compiled, self._context)
File "", line 23, in
File "C:\Users\Admin\AppData\Roaming\Python\Python310\site-packages\js2py\base.py", line 993, in callprop
raise MakeError('TypeError',
js2py.internals.simplex.JsException: TypeError: 'undefined' is not a function (tried calling property 'getAttribute' of 'Object')

I have gotten the same error as of yesterday on both .dlc and from txt with links. This used to work great. I hope both of our details can help you fix it

@Cartmanishere
Copy link
Owner

JFYI:

While I'm working on a fix, you can try with the text engine.

E.g.

python ./zippyshare.py --engine text

This seems to be working for me.

@redx113
Copy link

redx113 commented Aug 3, 2022

The python ./zippyshare.py --engine text

I pasted 242 links, it got up to 16 of the links than errored out with list index out of range. I am guess it must be limited to 16 links at a time, so as a workaround itll work, but definitely not as useful as the normal js engine. At least while you are working on the fix though, we have a slower 16 at a time workaround. Thanks for the alt info for now

Traceback (most recent call last):
File "D:\zippyshare-scraper-master\zippyshare.py", line 144, in
links, fails = zippy.parse_links(urls)
File "D:\zippyshare-scraper-master\zippyshare.py", line 68, in parse_links
extract, link = f.result()
File "C:\Program Files\Python310\lib\concurrent\futures_base.py", line 439, in result
return self.__get_result()
File "C:\Program Files\Python310\lib\concurrent\futures_base.py", line 391, in __get_result
raise self._exception
File "C:\Program Files\Python310\lib\concurrent\futures\thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "D:\zippyshare-scraper-master\zippyshare.py", line 33, in get_download_link
extract, link = self.engine.get_download_link(link)
File "D:\zippyshare-scraper-master\engines\text.py", line 40, in get_download_link
extract = self.parser(soup)
File "D:\zippyshare-scraper-master\engines\patterns\function.py", line 106, in pattern_3
d = int(soup.select('span[id="omg"]')[0].get('class')[0]) * 2
IndexError: list index out of range

@name01019
Copy link
Author

Now this method doesn't work either

python ./zippyshare.py --engine text

[] All patterns have failed
[
] All patterns have failed
[*] All patterns have failed

@Cartmanishere
Copy link
Owner

Cartmanishere commented Aug 20, 2022 via email

@name01019
Copy link
Author

Ok, I'll check it out.

On Sat, Aug 20, 2022 at 9:57 name01019 @.> wrote: Now this method doesn't work either python ./zippyshare.py --engine text [ ] All patterns have failed [] All patterns have failed [] All patterns have failed — Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFR3P3S3L5KQNBKE4NMUOR3V2AUN3ANCNFSM54NPH4RA . You are receiving this because you were mentioned.Message ID: @.*>

Oh actually, I just tried python3 zippyshare.py --dlc and it works now (even though it wasn't working a few weeks ago)

So it looks like dlc works now but engine text stopped working for some reason

@ztgasdf
Copy link

ztgasdf commented Nov 11, 2022

Still not working here. JSEngine is completely kaput and TextEngine works for a few links and then dies out with a list index out of range error.

@Cartmanishere
Copy link
Owner

Yeah, I am aware. They changed the site in a way that broke the JS Script logic. I still haven't found a workaround for it.

Unfortunately, the pattern-matching approach is the only option for now. i.e TextEngine.

I might be able to make it a bit more resilient. But don't get time to work on this these days 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@Cartmanishere @name01019 @redx113 @ztgasdf and others