From b2ebb5efcdc3abfefe7b47139d3d2bbee97943b1 Mon Sep 17 00:00:00 2001 From: e3ndr <33337309+e3ndr@users.noreply.github.com> Date: Fri, 20 Dec 2024 04:19:57 -0600 Subject: [PATCH] Found it... Forgot to install the Windows SDK... --- .github/workflows/maven.yml | 6 +++++- build.sh | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 6607157..a1f4cca 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -26,11 +26,15 @@ jobs: - name: 📦 Build the Windows artifact run: bash build.sh dist-windows - - name: 🔨 Create installer + - name: 🔨 Create Windows installer uses: joncloud/makensis-action@v4.1 with: script-file: "Installer.nsi" + - name: ✍️ Sign the Windows installer + shell: cmd + run: C:\signing\sign.bat Casterlabs-Caffeinated-Setup.exe + - name: 🆙 Upload the Windows artifact (x86_64) uses: actions/upload-artifact@v3 with: diff --git a/build.sh b/build.sh index 5cef09f..911a796 100644 --- a/build.sh +++ b/build.sh @@ -18,7 +18,7 @@ if [[ $@ == *"dist-windows"* ]]; then java -jar bundler.jar bundle \ --arch x86_64 --os windows \ --id $APP_ID --name $APP_NAME --icon icon.png \ - --sign 'cmd.exe /C C:\signing\sign.bat' \ + --sign 'cmd.exe /C C:\signing\sign.bat Casterlabs-Caffeinated.exe' \ --java 11 --arg=-Dcaffeinated.channel=stable --dependency target/Casterlabs-Caffeinated-Updater.jar --main $MAIN_CLASS echo "------------ Finished bundling for Windows ------------"