Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename forced downloads #232

Open
gerrewsb opened this issue Feb 10, 2025 · 6 comments
Open

Rename forced downloads #232

gerrewsb opened this issue Feb 10, 2025 · 6 comments
Labels
enhancement Request for a feature or improvement

Comments

@gerrewsb
Copy link

Description of the bug

since the latest release we are able to force a download when the regular download doesn't work or the volume name is slightly off. When forcing a download, the downloaded file(s) are not renamed like they are with a regular download.

To Reproduce

force a download

Expected behaviour

The the forced downloaded file(s) are renamed.

Version info

Key Value
Kapowarr version v1.1.0
Python version 3.8.17.final.0
Database version 34
Database location /app/db/Kapowarr.db
Data folder /app
@gerrewsb gerrewsb added the bug Report of something not working as expected label Feb 10, 2025
@Casvt
Copy link
Owner

Casvt commented Feb 11, 2025

This is intended behaviour. The fact that the content was downloaded with force suggests it probably won't match well to the volume and it's issues; there's a high chance of files not matching or matching wrong. So renaming has a high chance of only half of the files actually being renamed and those files being named wrong.

@Casvt Casvt closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2025
@gerrewsb
Copy link
Author

Everything i've forcefully downloaded and then renamed was correctly identified and renamed. And it was a lot of issues/volumes. When you manually download something with any other arr-stack app, it gets renamed according to your renaming settings. So calling this intended behavior seems lazy to me...

@Casvt
Copy link
Owner

Casvt commented Feb 11, 2025

It's not lazy at all. I actually had to do extra work to avoid them being renamed. I made a poll on Discord to check with other people whether the files match correctly for them often enough that we can confidently rename them by default. If so, I'll open the issue and implement the changes (mostly just removing the code that avoids it).

@Casvt Casvt changed the title Forced downloads are not renamed Rename forced downloads Feb 12, 2025
@Casvt Casvt added enhancement Request for a feature or improvement and removed bug Report of something not working as expected labels Feb 12, 2025
@Casvt Casvt reopened this Feb 12, 2025
@Casvt Casvt moved this to In Progress in Kapowarr plans Feb 12, 2025
Casvt added a commit that referenced this issue Feb 13, 2025
@Casvt Casvt moved this from In Progress to In Testing in Kapowarr plans Feb 13, 2025
@dadino
Copy link

dadino commented Feb 14, 2025

It doesn't unzip files with multiple issues either, right?

@gerrewsb
Copy link
Author

To be honest i haven't tested that yet.

@Casvt
Copy link
Owner

Casvt commented Feb 16, 2025

It should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for a feature or improvement
Projects
Status: In Testing
Development

No branches or pull requests

3 participants