You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To get the integration tests from gbif/checklistbank to work in the ported API involved assembling all the test data which is in format of the v1 species API in JSON, into a single CSV for the purposes of generating a test index.
It may make sense to replace all test data in the nub*.json files with a single CSV, or replace the nub*.json files with small CSVs (which might be easier to maintain).
Another option would be potentially switch to the texttree format.
The text was updated successfully, but these errors were encountered:
It was very convenient to use the matching response format to build the index. You could simply try out name matches that were problematic on the gbif API, store them locally as a seed to the index and create tests for it. Then work to fix the matching to respond as desired.
I fear that having the data in CSV or other formats quite some time is spent on preparing the test data. Could we not just continue with the old format? Or keep the old data as a single CSV but then allow to add new names via the new v2 matching response maybe?
My main concern was leaving a bunch of files that don't make too much sense for future developers maintaining the API as i assume v1 responses will eventually be deprecated and eventually be unavailable. Also the content of v2 responses wont fit into v1 (additional ranks, string keys etc).
For now I'll keep the existing files as they are and try and make it clear in the code its a format for v1 responses.
For the new API, we can follow the same model of using the matching response format in v2 to build the index and keep the v2 responses in separate directory.
To get the integration tests from gbif/checklistbank to work in the ported API involved assembling all the test data which is in format of the v1 species API in JSON, into a single CSV for the purposes of generating a test index.
Example of current format
It may make sense to replace all test data in the nub*.json files with a single CSV, or replace the nub*.json files with small CSVs (which might be easier to maintain).
Another option would be potentially switch to the texttree format.
The text was updated successfully, but these errors were encountered: