Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using photo picker #1261

Open
TheLastProject opened this issue Apr 5, 2023 · 7 comments
Open

Switch to using photo picker #1261

TheLastProject opened this issue Apr 5, 2023 · 7 comments
Assignees
@kevinMerizalde
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers severity: tolerable Low/no impact on users state: blocked by upstream Can't currently be done due to a limitation of Android or another upstream type: enhancement New feature or request

Comments

@TheLastProject
Copy link
Member

It's the new standard, let's use it:

https://developer.android.com/training/data-storage/shared/photopicker

I don't want to bother with auto-installing this stuff from Google Play Services, I personally dislike apps doing system-level things without permission. Just use it if available. We'll always use the picker for just one single image.

This will apply to all photo pickers. So:

  • Adding a card from file on the + screen
  • Setting an icon
  • Setting a photo
@TheLastProject TheLastProject added type: enhancement New feature or request good first issue Good for newcomers severity: tolerable Low/no impact on users common: occasional Affects or can be seen by some users regularly or most users rarely labels Apr 5, 2023
@kevinMerizalde
Copy link

I want to help with this. Could you assign this issue to me please?

@TheLastProject
Copy link
Member Author

Sure, good luck and thanks for wanting to help :)

@kevinMerizalde kevinMerizalde mentioned this issue May 4, 2023
Open
@TheLastProject TheLastProject added the state: blocked by upstream Can't currently be done due to a limitation of Android or another upstream label May 18, 2023
@akwa-peter
Copy link

@kevinMerizalde are you currently working on this?

@TheLastProject
Copy link
Member Author

This is currently not possible to implement because Google's photo picker hides many of the user's pictures: #1288 (comment)

@Abdullahkhanspn
Copy link

i will do this please assign to me can you explain this issue please @TheLastProject

@obfusk obfusk mentioned this issue Oct 15, 2023
Open
49 tasks
@rzuhovski0
Copy link
Contributor

Hello, is this issue still open? I would like to take a look at it.

@TheLastProject
Copy link
Member Author

As written above, this was already implemented in #1288 but it can't be merged because the photo picker doesn't show all of the user's images. Unless you know a way to fix that this issue is blocked and cannot be completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinMerizalde kevinMerizalde

Labels
common: occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers severity: tolerable Low/no impact on users state: blocked by upstream Can't currently be done due to a limitation of Android or another upstream type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@TheLastProject @akwa-peter @kevinMerizalde @rzuhovski0 @Abdullahkhanspn