Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on selecting color after rotation #1461

Closed
TheLastProject opened this issue Aug 3, 2023 · 1 comment · Fixed by #1463
Closed

Crash on selecting color after rotation #1461

TheLastProject opened this issue Aug 3, 2023 · 1 comment · Fixed by #1463
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow severity: major Severely degrades major functionality or product features, with no satisfactory workaround type: bug Something isn't working

Comments

@TheLastProject
Copy link
Member

How to reproduce:

  1. Go to the card editing screen
  2. Click the letter in the top left
  3. Click "Select color" in the "Set thumbnail" menu
  4. Rotate the screen
  5. Choose a color and click Select

Expected behaviour:
It changes the color

Actual behaviour:
Crash

Crash log:

Exception java.lang.IllegalStateException: The activity must implement ColorPickerDialogListener
  at com.jaredrummler.android.colorpicker.ColorPickerDialog.onColorSelected (ColorPickerDialog.java:583)
  at com.jaredrummler.android.colorpicker.ColorPickerDialog.access$000 (ColorPickerDialog.java:68)
  at com.jaredrummler.android.colorpicker.ColorPickerDialog$2.onClick (ColorPickerDialog.java:190)
  at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage (AlertController.java:167)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loopOnce (Looper.java:211)
  at android.os.Looper.loop (Looper.java:300)
  at android.app.ActivityThread.main (ActivityThread.java:8291)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:556)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1049)

This feels kinda similar to #1201, might have the same fix.

@TheLastProject TheLastProject added type: bug Something isn't working severity: major Severely degrades major functionality or product features, with no satisfactory workaround common: uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 3, 2023
@obfusk
Copy link
Contributor

obfusk commented Aug 3, 2023

Yeah I think you need to use a fragment here too. Will look into it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow severity: major Severely degrades major functionality or product features, with no satisfactory workaround type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants