Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Right-Handed Systems #315

Open
timbeaudet opened this issue Nov 9, 2023 · 4 comments
Open

Support for Right-Handed Systems #315

timbeaudet opened this issue Nov 9, 2023 · 4 comments

Comments

@timbeaudet
Copy link

The AllowAxisFlip() is great for keeping the gizmo from flipping, 😛, but it doesn't show the right coordinate-system for right-handed systems.

Would need to allow user to specify an axis to negate, in my case would be Z, to show properly for right-handed.

@timbeaudet
Copy link
Author

I was investigating making this change, and I found that changing directionUnary is the singular place it would need to happen, but that is const so a function that takes an index flip couldn't modify it.

void SetRightHandedAxis(int flippedAxis)
{
     directionUnary[flippedAxis][flippedAxis] = -1.0f;
}

Something like this is what I had in mind, though it requires that to be non-const and I don't think that would be a great first change without prior approval.

@timbeaudet
Copy link
Author

Upon further testing that change alone wouldn't quite enough, something broke with rotations.

@CedricGuillemet
Copy link
Owner

it sounds reasonable to me to add a new accessors to set right or left hand.

@timbeaudet
Copy link
Author

Any updates on that, I am curious if that will help the Y rotation flip/flop issue #294 which would basically be life saving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants